Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Staking e2e test - Add case when ledger active balance falls below ED #14247

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

gpestana
Copy link
Contributor

Adds e2e test that reproduces behaviour described in #14246, where staking ledger active balance may fall below ED and remain so until stash/controller withdraws unbonded funds after bonding period.

@gpestana gpestana added A0-please_review Pull request needs code review. I5-tests Tests need fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 27, 2023
@gpestana gpestana requested review from kianenigma and Ank4n May 27, 2023 21:28
@gpestana gpestana self-assigned this May 27, 2023
@gpestana gpestana requested review from a team May 27, 2023 21:28
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
@gpestana
Copy link
Contributor Author

gpestana commented Jun 5, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@stale
Copy link

stale bot commented Jul 9, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jul 9, 2023
@stale stale bot removed A3-stale labels Jul 10, 2023
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kianenigma
Copy link
Contributor

can be merged once conflict is resolved.

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 598c162

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit d584815 into master Jul 18, 2023
4 checks passed
@paritytech-processbot paritytech-processbot bot deleted the gpestana/14246-staking_e2e_ledger_state branch July 18, 2023 20:01
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…paritytech#14247)

* Staking e2e test - case when ledger active balance falls below ED

* Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs

Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>

* Simplifies test assertions; tests events

---------

Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: parity-processbot <>
Ank4n added a commit that referenced this pull request Jul 22, 2023
…#14247)

* Staking e2e test - case when ledger active balance falls below ED

* Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs

Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>

* Simplifies test assertions; tests events

---------

Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I5-tests Tests need fixing, improving or augmenting.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants