This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Staking e2e test - Add case when ledger active balance falls below ED #14247
Merged
paritytech-processbot
merged 6 commits into
master
from
gpestana/14246-staking_e2e_ledger_state
Jul 18, 2023
Merged
Staking e2e test - Add case when ledger active balance falls below ED #14247
paritytech-processbot
merged 6 commits into
master
from
gpestana/14246-staking_e2e_ledger_state
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
added
A0-please_review
Pull request needs code review.
I5-tests
Tests need fixing, improving or augmenting.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
May 27, 2023
Ank4n
reviewed
May 31, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
Ank4n
approved these changes
May 31, 2023
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
bot rebase |
…ing_e2e_ledger_state
Rebased |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
kianenigma
reviewed
Jul 10, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
Jul 10, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
Jul 10, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can be merged once conflict is resolved. |
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 598c162 |
bot merge |
Waiting for commit status. |
paritytech-processbot
bot
deleted the
gpestana/14246-staking_e2e_ledger_state
branch
July 18, 2023 20:01
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…paritytech#14247) * Staking e2e test - case when ledger active balance falls below ED * Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> * Simplifies test assertions; tests events --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: parity-processbot <>
Ank4n
added a commit
that referenced
this pull request
Jul 22, 2023
…#14247) * Staking e2e test - case when ledger active balance falls below ED * Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> * Simplifies test assertions; tests events --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
I5-tests
Tests need fixing, improving or augmenting.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds e2e test that reproduces behaviour described in #14246, where staking ledger active balance may fall below ED and remain so until stash/controller withdraws unbonded funds after bonding period.