This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
More generic extrinsic pool #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arkpar
commented
Aug 16, 2018
arkpar
commented
- Moved most of the common logic from polkadot transaction pool to substrate.
- Extrinsic hash type can now be different from the block hash type.
pepyakin
reviewed
Aug 16, 2018
substrate/service/src/lib.rs
Outdated
| "chain" => chain_name.clone(), | ||
| "pubkey" => &pubkey, | ||
| ); | ||
| "name" => name.clone(), |
There was a problem hiding this comment.
Looks like there are some spaces sneaked in.
There was a problem hiding this comment.
Why this was indentend anyway?
substrate/service/src/lib.rs
Outdated
| Err(e) => match e.into_pool_error() { | ||
| Ok(e) => match e.kind() { | ||
| extrinsic_pool::ErrorKind::AlreadyImported(hash) => | ||
| Some(::std::str::FromStr::from_str(&hash).map_err(|_| {}).expect("Hash string is always valid")), |
substrate/service/src/lib.rs
Outdated
| }, | ||
| }, | ||
| Err(e) => { | ||
| debug!("Error converting pool error: {:?}", e); |
There was a problem hiding this comment.
The indentation looks a bit off here
substrate/service/src/lib.rs
Outdated
| state, | ||
| chain, | ||
| author, | ||
| rpc_config.clone(), | ||
| ) | ||
| ) |
substrate/rpc/src/author/tests.rs
Outdated
| type Extrinsic = u64; | ||
| type Hash = u64; | ||
| #[derive(Clone, Debug)] | ||
| pub struct Verified(u64, u64); // sender, nonce |
There was a problem hiding this comment.
Wouldn't it be more readable if it were a normal struct instead of a tuple?
arkpar
force-pushed
the
a-ex-pool-refactor
branch
2 times, most recently
from
7be70d2
to
24ddf08
Compare
arkpar
force-pushed
the
a-ex-pool-refactor
branch
from
24ddf08
to
bbd69db
Compare
gavofyork
approved these changes
Aug 20, 2018
gavofyork
added
A8-looksgood
and removed
A0-please_review
|
looks reasonable. |
dvdplm
added a commit
that referenced
this pull request
Aug 27, 2018
…and-rlpcodec * master: More generic extrinsic pool (#579)
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Update wasm build step * Update pre_release ci * Minimize change Co-authored-by: alannotnerd <alan1995wang@outlook.com>
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* cli: Support ws or wss connection via jsonrpsee Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * cli: Handle `http` connections via `ureq` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * cli: Use Jsonrpsee HTTP client Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * cli: Remove `node.to_string()` calls Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.