Make web and native feature explicit opt in in signer crate #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooohhh, this is my bad; I thought that with Subxt you had to explicitly opt in to both, but when I checked just now Ican see that Subxt enables the "native" feature by default already, because otherwise So actually I was wrong about this and I don't think you need to change that after all; sorry! |
|
So yup, I think the only things I'd change are: #1200. Sorry for sending you down the wrong track! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
subxt-signercrate with thesubxtfeature enabled, now one has to explicitly opt in to thewebor thenativefeature. Failure to do so, yields a compile error.(Changes some of the things I did in #1193)