-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to fetch an unhashed key, close #100 #152
Add a method to fetch an unhashed key, close #100 #152
Conversation
@en, Your signature has been received. |
src/lib.rs
Outdated
&self, | ||
key: &StorageKey, | ||
hash: Option<T::Hash>, | ||
) -> Result<Option<StorageData>, Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to also perform the decoding rather than return just the raw data?
} else { | ||
Ok(None) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing: could you modify fetch
below 👇 to call this method just to reduce the duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.