Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone for the generated RuntimeApi #544

Merged
merged 4 commits into from May 16, 2022
Merged

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented May 13, 2022

This PR offers customers the ability to clone the RuntimeAPI.

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
subxt/src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Copy link
Contributor Author

lexnv commented May 13, 2022

Good point, i ll manually implement Clone to avoid introducing any bounds

lexnv added 2 commits May 13, 2022 18:06
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff :)

@jsdw jsdw requested a review from a team May 16, 2022 12:18
@jsdw jsdw merged commit fc19f88 into master May 16, 2022
@jsdw jsdw deleted the clone_runtime_api branch May 16, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants