Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating/submitting unsigned transactions, too. #625

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Allow creating/submitting unsigned transactions, too. #625

merged 2 commits into from
Aug 18, 2022

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Aug 17, 2022 •
edited
Loading

  • add create_unsigned call to build unsigned extrinsics.
  • rename SignedSubmittableExtrinsic to SubmittableExtrinsic (since you can now get one from an unsigned tx too).
  • expose encoded() from this for OfflineClients too.

Todo:

  • Add some sort of end to end test to make sure valid calls are generated

@jsdw jsdw changed the title add a create_unsigned method to work with unsigned transactions, too Allow creating/submitting unsigned transactions, too. Aug 17, 2022
niklasad1
niklasad1 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsdw jsdw merged commit a71223a into master Aug 18, 2022
@jsdw jsdw deleted the jsdw-unsigned-tx branch August 18, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsdw @niklasad1 @lexnv