Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ChainBlockExtrinsic cloneable #778

Merged
merged 1 commit into from
Jan 16, 2023
Merged

make ChainBlockExtrinsic cloneable #778

merged 1 commit into from
Jan 16, 2023

Conversation

abhijeetbhagat
Copy link
Contributor

No description provided.

@abhijeetbhagat
Copy link
Contributor Author

looks like the test definitely failed due to the missing scale file?

@lexnv
Copy link
Collaborator

lexnv commented Jan 16, 2023

The tests are currently failing due to #779.
It seems to be unrelated to this PR; meanwhile, I'll look into fixing the issue before continuing with the merge.

This PR looks good to me at first glance. Could you describe your use case for this?
I'm wondering if there is anything else we should make Clonable as well

@niklasad1
Copy link
Member

niklasad1 commented Jan 16, 2023 •
edited
Loading

This PR looks good to me at first glance. Could you describe your use case for this?

I think it's just more convenient as the underlying Vec is public anyway so instead of cloning the Vec this PR makes it possible to clone the entire type. Looks good

@jsdw jsdw merged commit 25245ad into paritytech:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhijeetbhagat @lexnv @niklasad1 @jsdw