Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create raw payload in Client #83

Merged
merged 1 commit into from
Apr 3, 2020
Merged

create raw payload in Client #83

merged 1 commit into from
Apr 3, 2020

Conversation

whalelephant
Copy link
Contributor

ref to #82 - explore the method on Client

ascjones
ascjones approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is scope to remove some duplication here with create_and_sign, but we can do that in a follow up.

@ascjones ascjones merged commit bb46578 into paritytech:master Apr 3, 2020
@whalelephant
Copy link
Contributor Author

Do let me know if you want it structured differently and remove dups. Thanks!!

@ascjones ascjones mentioned this pull request Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whalelephant @ascjones