Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Header and Hasher for some substrate types behind the "substrate-compat" feature flag #934

Merged
merged 2 commits into from Apr 27, 2023
Merged

impl Header and Hasher for some substrate types behind the "substrate-compat" feature flag #934

merged 2 commits into from Apr 27, 2023

Conversation

tadeohepperle
Copy link
Contributor

@tadeohepperle tadeohepperle commented Apr 26, 2023 •
edited

fixes #835.

This PR I implements subxts Hasher trait for:

  • sp_core::Blake2Hasher
  • sp_core::KeccakHasher

and subxts Header trait for:

  • sp_runtime::generic::Header

I don't know if there are other types for which I should implement the traits as well, please let me know.

@tadeohepperle tadeohepperle requested a review from a team as a code owner April 26, 2023 17:17
jsdw
jsdw approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm not sure whether we've covered everything, but looks good offhand and if people run into issues then we can add more impls or whatever :)

lexnv
lexnv approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@jsdw jsdw merged commit b7c5d76 into master Apr 27, 2023
10 checks passed
@jsdw jsdw deleted the tadeo-hepperle-substrate-hasher-and-header-traits branch April 27, 2023 15:00
@jsdw jsdw mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdw jsdw jsdw approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tadeohepperle @jsdw @niklasad1 @lexnv