This repository was archived by the owner on Jan 17, 2022. It is now read-only.
The constructor arg removed from #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
reviewed
Aug 6, 2018
| &path, | ||
| ctor_module.expect("ctor_module can't be None, because 'constructor' argument is set to true in build"), | ||
| ).map_err(Error::Encoding)?; | ||
| if let Some(ctor_module) = ctor_module { |
There was a problem hiding this comment.
Just a grumble -- this interface looks a little bit confusing to me: if no deploy symbol is defined, and we run wasm-build without --save-raw, then no file will be written? Maybe we can return a warning in the above case or just change it so that "no deploy symbol" is equivalent to --save-raw?
There was a problem hiding this comment.
Indeed, it worked like you say before the #97
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.