Don't share locks across UI thread and long running processes #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantland
added
type:bug
|
LGTM |
`setConnected` uses the same lock we use for synchronizing disk I/O, so there's a possibility that we can block the UI thread on disk I/O, so we're going to bump the lock usage to a different thread.
grantland
force-pushed
the
grantland.ui_thread
branch
from
b7f10b8 to
4d5096d
Compare
grantland
added a commit
that referenced
this pull request
Sep 4, 2015
Don't share locks across UI thread and long running processes
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setConnecteduses the same lock we use for synchronizing disk I/O, so there's a possibilitythat we can block the UI thread on disk I/O, so we're going to bump the lock usage to a
different thread.
Related Bug: https://developers.facebook.com/bugs/838833329491346/