-
-
Notifications
You must be signed in to change notification settings - Fork 102
Set Server URL, Set Insecure #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add method to set custom server URL and call setInsecure() function in connection client.
Hi thanks for the PR. As you may have seen in the readme we have retired this project due to lack of contribution, however we are open to having a new maintainer take over. Would you be interested/able to do that? |
Good morning Tom,
I would be happy to take over. I modified the current arduino parse library to work with an esp8266 project of mine, and I wanted to make sure I contributed my work in getting my IoT project functional.
I'm new to GitHub, but happy to learn. Let me know what you need from me to take over.
Thanks,
Derrick
On Tuesday, February 11, 2020, 10:59:15 AM PST, Tom Fox <notifications@github.com> wrote:
Hi thanks for the PR.
As you may have seen in the readme we have retired this project due to lack of contribution, however we are open to having a new maintainer take over. Would you be interested/able to do that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Great to hear. Usually we would escalate permissions gradually as we gain trust in the contributor and they bring value to the project. However, in this case as there are no existing maintainers it makes more difficult to onboard new contributors so I'll talk to the other members of the core team to decide the best way to proceed. |
why insecure? |
The WiFiClientSecure object wont connect unless the host fingerprint is provided OR setInscure is called. The client.setFingerprint() can be called before connecting, and a ParseClient::setHostFingerprint could be added as well. The caveat is that the fingerprint may change without warning, breaking the API functionality... Thoughts? |
the only thought i have is: ssl should always be used in 2020. I'm assuming that this turns off ssl having said that, if its the only solution (assuming i'm even on the right trail here), then so be it lets merge it. just asking to make sure. |
I agree with the need for SSL. I just tested adding ParseClient::setHostFingerprint("FINGERPRINT HERE"), and it functions well. We could also add ParseClient::setClientInsecure(true) to call client.setInsecure() These would expose the configuration to the IDE to support either option. This is probably a better approach? |
if the fingerprint is reliable, then certainly use that. exposing both also seems fine. |
Add method to set custom server URL and call setInsecure() function in connection client.