Skip to content

Conversation

DJMarlow
Copy link
Contributor

Add method to set custom server URL and call setInsecure() function in connection client.

Add method to set custom server URL and call setInsecure() function in connection client.
@TomWFox
Copy link
Contributor

TomWFox commented Feb 11, 2020

Hi thanks for the PR.

As you may have seen in the readme we have retired this project due to lack of contribution, however we are open to having a new maintainer take over. Would you be interested/able to do that?

@DJMarlow
Copy link
Contributor Author

DJMarlow commented Feb 11, 2020 via email

@TomWFox
Copy link
Contributor

TomWFox commented Feb 11, 2020

Great to hear. Usually we would escalate permissions gradually as we gain trust in the contributor and they bring value to the project. However, in this case as there are no existing maintainers it makes more difficult to onboard new contributors so I'll talk to the other members of the core team to decide the best way to proceed.

@acinader
Copy link
Contributor

why insecure?

@DJMarlow
Copy link
Contributor Author

why insecure?

The WiFiClientSecure object wont connect unless the host fingerprint is provided OR setInscure is called.

The client.setFingerprint() can be called before connecting, and a ParseClient::setHostFingerprint could be added as well. The caveat is that the fingerprint may change without warning, breaking the API functionality...

Thoughts?

@acinader
Copy link
Contributor

the only thought i have is: ssl should always be used in 2020. I'm assuming that this turns off ssl

having said that, if its the only solution (assuming i'm even on the right trail here), then so be it lets merge it. just asking to make sure.

@DJMarlow
Copy link
Contributor Author

the only thought i have is: ssl should always be used in 2020. I'm assuming that this turns off ssl

having said that, if its the only solution (assuming i'm even on the right trail here), then so be it lets merge it. just asking to make sure.

I agree with the need for SSL.

I just tested adding ParseClient::setHostFingerprint("FINGERPRINT HERE"), and it functions well.

We could also add ParseClient::setClientInsecure(true) to call client.setInsecure()

These would expose the configuration to the IDE to support either option.

This is probably a better approach?

@acinader
Copy link
Contributor

if the fingerprint is reliable, then certainly use that.

exposing both also seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants