LiveList/LiveQuery nullsafety #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might have to discuss, wether we consider this to be a breaking change compared to 3.0.0. I have named the new version 3.0.1 for now. I think this should be fine. This change makes sense, as setting object to null (possible with the prior default constructor) would brake the whole QueryBuilder.
this should break nothing and instead fix forced not-null casts on null objects
this makes the code easier to maintain
this makes the code easier to maintain
this should break nothing and instead fix forced not-null casts on null objects
this should break nothing and instead remove forced not-null casts on null objects
this should break nothing and instead remove forced not-null casts on null objects
I think those where missed when splitting the package.
This fixes a bug where a "Null check operator used on a null value"-error
I've broken this part while removing the not-null casts. My second attempt works :-)
|
Hey @fischerscode. Very good. Change the version to 3.1.0. I'm validating other PR and will ask @phillwiggins to release this fix and other improvements next week. |
|
@RodrigoSMarques |
|
@fischerscode I notice that you have currently access to this repository, granted on an individual basis. Since we are moving to team-managed permissions, I will go ahead and convert your permissions by inviting you to the repository as team member and removing your individually granted access. Please let me know if you have any questions. |
|
@mtrezza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: No new features, just fixes arround the ParseLiveList.
While migrating my app, I've noticed LiveList has been broken due to the null-safety migration. I've decided to go through the entire LiveQuery and LiveList part in order to remove those not-null casts (
something!).Additionally I've changed
objectinQueryBuilderfrom nullable to not-nullable. In theory this is a breaking change, as we formally allowed null as the argument in the default constructor before. But as setting it to null would result in a crash, I think we should be fine with updating the version number to just "3.0.1".Close #612