Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 11, 2021

Allowing the test suite to run in a random order will help find test passes only based on a previously ran test.

  • Adds new Parse.Object.unregisterSubclass feature
  • Properly closes test created servers
  • Generate unique username and password for user tests
  • Properly handle unsorted queries (results returned in random order)
  • Improve tests with background operations
  • Remove setTimeout when possible

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1317 (ebedc02) into master (724485d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         5847      5853    +6     
  Branches      1312      1313    +1     
=========================================
+ Hits          5847      5853    +6     
Impacted Files Coverage Δ
src/ParseObject.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724485d...3ae501a. Read the comment docs.

@dplewis dplewis requested review from davimacedo and mtrezza March 11, 2021 22:13
@dplewis
Copy link
Member Author

dplewis commented Mar 11, 2021

@davimacedo @mtrezza I ran the entire suite 20 times locally without any issues. This should be good to go.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice, I expected more fails, let's see how Parse Server does randomized.

@dplewis dplewis merged commit 70321e4 into master Mar 11, 2021
@dplewis dplewis deleted the random-tests branch March 11, 2021 22:33
@dplewis
Copy link
Member Author

dplewis commented Mar 11, 2021

I hope so there are 2800 test in the server repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants