Live Queries Support. #225
Conversation
src/CoreManager.js
Outdated
| throw new Error('LiveQueryController must implement open()'); | ||
| } | ||
| if (typeof controller.close !== 'function') { | ||
| throw new Error('LiveQueryController must implement disconnect()'); |
There was a problem hiding this comment.
Nit: change to LiveQueryController must implement close()
peterdotjs
force-pushed
the
peterjs.liveQuery
branch
from
63b8ea3 to
7a49ca7
Compare
|
Updated per comments. |
|
This all looks good to me. I'll do one last pass, then merge into the 1.8 release branch, followed by merging that into master. If the rye tests I just landed all pass, I'll cut a second RC on |
src/ParseLiveQuery.js
Outdated
|
|
||
| // If we can not find Parse.liveQueryServerURL, we try to extract it from Parse.serverURL | ||
| if (!liveQueryServerURL) { | ||
| let host = url.parse(CoreManager.get('SERVER_URL')).host; |
There was a problem hiding this comment.
This should really be a regex. There's no need to import the entire url browserify module, it's too much overhead (I know we've discussed this at least once before :).
It seems like what we really want is something like:
let host = CoreManager.get('SERVER_URL').replace(/^https?:\/\//, '');There was a problem hiding this comment.
Yeah I remember. I didn't write this part but I did miss it in the review so good catch. The url package wasn't even in package.json so this part was a miss overall.
|
Made the changes, everything is merged. You can fetch the latest version of 1.8.0 with |
cc: @wangmengyan95