Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 4, 2019

  • Fixes unhandled promise rejection in LiveQuery-tests
(node:5669) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'send' of undefined
(node:5669) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). 
  • ParseACLTest weren't waiting for Parse.User.logOut, there were so many I decided to rewrite the tests
Failures:
1) Parse.ACL allows logged in get
  Message:
    Unhandled promise rejection: ParseError: 101 Object not found for delete.
  Stack:
    error properties: Object({ code: 101 })
    Error: Object not found for delete.
        at /home/travis/build/parse-community/Parse-SDK-JS/lib/node/RESTController.js:324:19
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)
2) Parse.ACL allows logged in find
  Message:
    Unhandled promise rejection: ParseError: 107 schema class name does not revalidate
  Stack:
    error properties: Object({ code: 107 })
    Error: schema class name does not revalidate
        at /home/travis/build/parse-community/Parse-SDK-JS/lib/node/RESTController.js:324:19
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)
3) Parse.ACL allows logged in update
  Message:
    Unhandled promise rejection: ParseError: 107 schema class name does not revalidate
  Stack:
    error properties: Object({ code: 107 })
    Error: schema class name does not revalidate
        at /home/travis/build/parse-community/Parse-SDK-JS/lib/node/RESTController.js:324:19
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)
4) Parse.ACL allows logged in delete
  Message:
    Unhandled promise rejection: ParseError: 107 schema class name does not revalidate
  Stack:
    error properties: Object({ code: 107 })
    Error: schema class name does not revalidate
        at /home/travis/build/parse-community/Parse-SDK-JS/lib/node/RESTController.js:324:19
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)
5) Parse.ACL enables get with public read
  Message:
    Unhandled promise rejection: ParseError: 107 schema class name does not revalidate
  Stack:
    error properties: Object({ code: 107 })
    Error: schema class name does not revalidate
        at /home/travis/build/parse-community/Parse-SDK-JS/lib/node/RESTController.js:324:19
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)
6) Parse.ACL enables find with public read
  Message:
    Unhandled promise rejection: ParseError: 101 Object not found.
  Stack:
    error properties: Object({ code: 101 })
    Error: Object not found.
        at /home/travis/build/parse-community/Parse-SDK-JS/lib/node/RESTController.js:324:19
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)
7) Parse.ACL does not enable update with public read
  Message:
    Unhandled promise rejection: AssertionError [ERR_ASSERTION]: false == true
  Stack:
    error properties: Object({ generatedMessage: true, code: 'ERR_ASSERTION', actual: false, expected: true, operator: '==' })
        at <Jasmine>
        at user.signUp.then.then.then.then (/home/travis/build/parse-community/Parse-SDK-JS/integration/test/ParseACLTest.js:244:7)
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)
Pending:

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #788 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          54       54           
  Lines        4908     4908           
  Branches     1087     1087           
=======================================
  Hits         4516     4516           
  Misses        392      392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582635e...6c0a211. Read the comment docs.

@dplewis dplewis merged commit c91ebd6 into master Apr 4, 2019
@dplewis dplewis deleted the flaky-tests-acl branch April 4, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants