Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 11, 2019

I believe we can break this up into multiple PR's

This PR covers half of the flow errors (out of 375) without functionality changes.

The next half will need to be reviewed with a fine tooth comb

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #790 into master will increase coverage by <.01%.
The diff coverage is 93.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   92.01%   92.01%   +<.01%     
==========================================
  Files          54       54              
  Lines        4908     4909       +1     
  Branches     1087     1087              
==========================================
+ Hits         4516     4517       +1     
  Misses        392      392
Impacted Files Coverage Δ
src/CoreManager.js 100% <ø> (ø) ⬆️
src/ParseFile.js 97.51% <ø> (ø) ⬆️
src/Storage.js 96.15% <100%> (ø) ⬆️
src/ParseObject.js 90.02% <100%> (ø) ⬆️
src/LocalDatastore.js 98.66% <100%> (-0.02%) ⬇️
src/ParseSession.js 89.74% <100%> (ø) ⬆️
src/parseDate.js 100% <100%> (ø) ⬆️
src/ParseConfig.js 87.95% <100%> (ø) ⬆️
src/LocalDatastoreController.react-native.js 100% <100%> (ø) ⬆️
src/InstallationController.js 91.3% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91ebd6...6ea042f. Read the comment docs.

@dplewis dplewis requested a review from acinader April 11, 2019 17:50
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. Can you give some insight on you thinking about the switch to flow-weak?

@dplewis
Copy link
Member Author

dplewis commented Apr 11, 2019

I removed it in this case. Its used when you can't figure out flow type errors or there are too many to handle at the present moment.

@dplewis dplewis merged commit 05e8c79 into master Apr 11, 2019
@dplewis dplewis deleted the flow-layout branch April 11, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants