Remove all usages of the PF_GENERIC macro. #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One nit left, otherwise - LGTM! |
|
Actually, it looks like you missed few places. |
richardjrossiii
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
richardjrossiii
force-pushed
the
richardross.pfgeneric.kill
branch
from
0a15ffe to
465db9d
Compare
richardjrossiii
force-pushed
the
richardross.pfgeneric.kill
branch
from
465db9d to
883fb0a
Compare
This is no longer needed as we will not be supporting Xcode 6 in the future. Fixes #674.
richardjrossiii
force-pushed
the
richardross.pfgeneric.kill
branch
from
883fb0a to
20db241
Compare
richardjrossiii
added a commit
that referenced
this pull request
Jan 5, 2016
Remove all usages of the PF_GENERIC macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #674.
Note: This PR was mostly generated by a tool. I have manually reviewed the diff on my end for correctness, as well. Feel free to skim this one, tests should be enough to make sure nothing important broke.