Skip to content

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 2, 2021

Reasoning/discussion in #113. This is a breaking changing, but will allow for easier and more predictable use of ParseInstallation. If the developer wants to save the latest badge value, they should retrieve it before saving the installation.

Fix #113

  • Remove the usage of UIKit and AppKit in the SDK.
  • Removed dispatching when using ParseInstallation
  • Updated playgrounds
  • Added changelog entry
  • Updated Installation documentation
  • Prepare for new release

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #114 (a088b86) into main (3852a93) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head a088b86 differs from pull request most recent head a92856e. Consider uploading reports for the commit a92856e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   81.06%   80.95%   -0.11%     
==========================================
  Files          65       65              
  Lines        5482     5461      -21     
==========================================
- Hits         4444     4421      -23     
- Misses       1038     1040       +2     
Impacted Files Coverage Δ
Sources/ParseSwift/Storage/KeychainStore.swift 97.75% <ø> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 82.54% <100.00%> (-0.69%) ⬇️
Sources/ParseSwift/Parse.swift 100.00% <100.00%> (ø)
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 0.00% <0.00%> (-20.00%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 81.22% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3852a93...a92856e. Read the comment docs.

@cbaker6 cbaker6 requested a review from TomWFox April 2, 2021 15:07
@cbaker6
Copy link
Contributor Author

cbaker6 commented Apr 2, 2021

@TomWFox can you look over the updated docs for ParseInstallation when you get a chance?

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cbaker6 cbaker6 merged commit f4ee1b9 into main Apr 3, 2021
@cbaker6 cbaker6 deleted the removeDispatch branch April 3, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove automatic retrieval of badge in ParseInstallation
2 participants