-
-
Notifications
You must be signed in to change notification settings - Fork 70
Add unit tests for API, ParseObject, and ParseUser #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pranjalsatija I attempted to minimize merge conflicts with #13 by touching little of the code you edited. I know you made a modification to |
@TomWFox @pranjalsatija when you get a chance can you look this over? It’s mostly unit tests verifying that the codebase is working as expected.It also has some minor updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for a few really minor things!
LGTM! We can touch one or two things up once all the open PRs are merged. |
@pranjalsatija can you take another look at this and then I can merge? |
@pranjalsatija the only real changes I made since your last review are the minor ones I made to MockURLProtocol.swift and MockURLResponse.swift, the other SPM files I added, I deleted later as they weren't needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry about the delay / general unresponsiveness, I'm out of town this week, but I'll be back in action on Friday.
@TomWFox no more changes from me on this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the org name!
Items added:
This is ready for review...