Skip to content

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Aug 1, 2021

Check states of WebSocket during a not connected error and proceed accordingly.

  • add change log entry

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #207 (2564cbf) into main (49e8083) will decrease coverage by 0.26%.
The diff coverage is 68.42%.

❗ Current head 2564cbf differs from pull request most recent head 9426f91. Consider uploading reports for the commit 9426f91 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   83.08%   82.82%   -0.27%     
==========================================
  Files          76       76              
  Lines        7224     7242      +18     
==========================================
- Hits         6002     5998       -4     
- Misses       1222     1244      +22     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 42.64% <50.00%> (-12.43%) ⬇️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.22% <69.44%> (-2.49%) ⬇️
Sources/ParseSwift/Types/Query.swift 95.11% <0.00%> (+0.15%) ⬆️
Sources/ParseSwift/Coding/AnyEncodable.swift 61.84% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e8083...9426f91. Read the comment docs.

@cbaker6 cbaker6 merged commit a6e949e into main Aug 1, 2021
@cbaker6 cbaker6 deleted the live branch August 1, 2021 21:22
cbaker6 added a commit that referenced this pull request Aug 1, 2021
* ParseLiveQuery checks all states of a websocket

* Added completion handler to resumeTask

* remove some changes to resumeTask

* Update .codecov.yml

* Remove extra receives

* Add closeAll back

* remove delegate if needed

* Call open when error received

* Call open when attempting to reconnect to add delay

* Remove closeAll test. LiveQuery test a little flaky
cbaker6 added a commit that referenced this pull request Aug 1, 2021
* Add docs for defaultDataDirectoryPath

* ParseLiveQuery checks all states of a websocket (#207)

* ParseLiveQuery checks all states of a websocket

* Added completion handler to resumeTask

* remove some changes to resumeTask

* Update .codecov.yml

* Remove extra receives

* Add closeAll back

* remove delegate if needed

* Call open when error received

* Call open when attempting to reconnect to add delay

* Remove closeAll test. LiveQuery test a little flaky

* Fix changelog

* Update .codecov.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant