Skip to content

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Aug 5, 2021

Ensure that LiveQuery delegate always receives connection errors. Previously, an error that occurs after a resumeTask may not be passed to the delegate.

  • Fix reconnections when the LiveQuery server is restarted or disconnected
  • Add test cases
  • Add playground example
  • Add change log entry

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #211 (c712a0f) into main (edbe3c6) will increase coverage by 0.14%.
The diff coverage is 75.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   82.84%   82.99%   +0.14%     
==========================================
  Files          76       76              
  Lines        7250     7290      +40     
==========================================
+ Hits         6006     6050      +44     
+ Misses       1244     1240       -4     
Impacted Files Coverage Δ
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 16.66% <ø> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 74.38% <71.92%> (+2.01%) ⬆️
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 60.25% <100.00%> (+15.97%) ⬆️
Sources/ParseSwift/Coding/AnyEncodable.swift 61.18% <0.00%> (-0.66%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 75.99% <0.00%> (-0.31%) ⬇️
Sources/ParseSwift/Types/Query.swift 94.95% <0.00%> (-0.16%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 82.74% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edbe3c6...c712a0f. Read the comment docs.

@cbaker6 cbaker6 merged commit 38caf2e into main Aug 6, 2021
@cbaker6 cbaker6 deleted the liveQueryError branch August 6, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant