Skip to content

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Sep 11, 2021

New Pull Request Checklist

Issue Description

Saving a ParseObject with a ParseFile halts the main queue.

Related issue: #229

Approach

Save ParseObject's with embedded ParseFiles save on the background queue.

TODOs before merging

  • When saving/fetching ParseFile's synchronously, allow the developer to specify the return queue
  • Add entry to changelog
  • Add playgrounds example
  • Prepare for release

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 11, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 11, 2021

@dblythy can you check this branch to see if your problem is fixed?

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #230 (0c56cf7) into main (f767242) will decrease coverage by 0.00%.
The diff coverage is 90.32%.

❗ Current head 0c56cf7 differs from pull request most recent head d1c9180. Consider uploading reports for the commit d1c9180 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   83.71%   83.70%   -0.01%     
==========================================
  Files          76       76              
  Lines        7318     7329      +11     
==========================================
+ Hits         6126     6135       +9     
- Misses       1192     1194       +2     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseFile.swift 85.65% <87.50%> (-0.19%) ⬇️
Sources/ParseSwift/API/URLSession+extensions.swift 75.00% <100.00%> (+0.21%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 78.26% <100.00%> (-0.06%) ⬇️
Sources/ParseSwift/Types/ParseError.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f767242...d1c9180. Read the comment docs.

@cbaker6 cbaker6 changed the title Save ParseFiles on background queue fix: Saving ParseFiles occur on the background queue Sep 11, 2021
@cbaker6 cbaker6 linked an issue Sep 11, 2021 that may be closed by this pull request
4 tasks
@cbaker6 cbaker6 changed the title fix: Saving ParseFiles occur on the background queue fix: Saving ParseFiles occurs on the background queue Sep 11, 2021
@cbaker6 cbaker6 merged commit 85e8bd7 into main Sep 12, 2021
@cbaker6 cbaker6 deleted the multipleFiles branch September 12, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving a Object with an Array of Files holds UI thread
1 participant