Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only encode email on ParseUser if different from Keychain #256

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 14, 2021

New Pull Request Checklist

Issue Description

Builds onto #241 to ensure to only encode email if different from Keychain on Apple devices.

Related issue: #239

Approach

Compare email against Keychain email on Apple devices.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Documentation nits
  • Prepare for release

@cbaker6 cbaker6 linked an issue Oct 14, 2021 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #256 (db63447) into main (1385abf) will increase coverage by 0.03%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   76.75%   76.79%   +0.03%     
==========================================
  Files          98       98              
  Lines       10403    10412       +9     
==========================================
+ Hits         7985     7996      +11     
+ Misses       2418     2416       -2     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseInstallation.swift 77.36% <0.00%> (ø)
Sources/ParseSwift/Parse.swift 98.72% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 79.85% <100.00%> (+0.19%) ⬆️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.94% <0.00%> (-0.15%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 73.60% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1385abf...db63447. Read the comment docs.

@cbaker6 cbaker6 merged commit c53abab into main Oct 14, 2021
@cbaker6 cbaker6 deleted the emailUpdates branch October 14, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification Emails are triggered every time User.current is saved
1 participant