Skip to content

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 28, 2021

New Pull Request Checklist

Issue Description

SDK is capable be being built for Windows, but a windows build currently isn't in the CI.

Related issue: #n/a

Approach

Add windows build to CI

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 28, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 28, 2021

@mtrezza can you add the Windows build to the required builds? Also, can you add "Windows" to the "About" section of this repo?

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #290 (c944f0c) into main (7c53ef3) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   82.44%   82.46%   +0.01%     
==========================================
  Files         104      104              
  Lines       10607    10607              
==========================================
+ Hits         8745     8747       +2     
+ Misses       1862     1860       -2     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser.swift 80.04% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c53ef3...c944f0c. Read the comment docs.

@cbaker6 cbaker6 merged commit ae47862 into parse-community:main Nov 29, 2021
@cbaker6 cbaker6 deleted the cbaker6-patch-1 branch November 29, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant