Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make variadic call array counterparts #301

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Dec 13, 2021

New Pull Request Checklist

Issue Description

SDK currently duplicates code for variadic calls that have array counterparts.

Related issue: #n/a

Approach

Reduce call sites by having all methods with variadic arguments call their array counterparts.

This not only reduces the code footprint, but removes the chances of different implementations between methods.

TODOs before merging

  • Check that tests still pass
  • Add any missing inits for variadic/array counterparts
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 13, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #301 (6b66f61) into main (ebaaf12) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   83.66%   83.64%   -0.03%     
==========================================
  Files         105      105              
  Lines       11187    11168      -19     
==========================================
- Hits         9360     9341      -19     
  Misses       1827     1827              
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParsePolygon.swift 93.81% <100.00%> (-0.07%) ⬇️
Sources/ParseSwift/Types/Query.swift 92.61% <100.00%> (-0.24%) ⬇️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.92% <0.00%> (-0.74%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 80.73% <0.00%> (+0.01%) ⬆️
Sources/ParseSwift/Objects/ParseInstallation.swift 80.66% <0.00%> (+0.02%) ⬆️
Sources/ParseSwift/API/API+Command.swift 83.77% <0.00%> (+0.47%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 81.94% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaaf12...6b66f61. Read the comment docs.

@cbaker6 cbaker6 merged commit a15114b into parse-community:main Dec 13, 2021
@cbaker6 cbaker6 deleted the refactorVariadic branch December 13, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant