fix: check for ParseError first after server response

[cbaker6]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

Currently tries to decode response as object before checking for error.

Related issue: #313

Approach

Always check if an error can be decoded first.

TODOs before merging

• Check CI passes

[parse-github-assistant]

Thanks for opening this pull request!

• 🎉 We are excited about your hands-on contribution!

[cbaker6]

@Climbatize @vdkdamian can you check if this branch solves the problem?

Also check if all other functionality works as normal. I'll take a further look later...

[codecov]

Codecov Report

Merging #332 (afbd466) into main (96232f3) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   85.11%   85.03%   -0.09%     
==========================================
  Files         114      114              
  Lines       12116    12118       +2     
==========================================
- Hits        10312    10304       -8     
- Misses       1804     1814      +10     

Impacted Files	Coverage Δ
Sources/ParseSwift/Extensions/URLSession.swift	72.72% <100.00%> (+0.26%)	⬆️
...urces/ParseSwift/API/API+NonParseBodyCommand.swift	74.52% <0.00%> (-1.28%)	⬇️
Sources/ParseSwift/Types/ParseAnalytics.swift	97.45% <0.00%> (-1.28%)	⬇️
Sources/ParseSwift/API/API+Command.swift	84.23% <0.00%> (-0.42%)	⬇️
Sources/ParseSwift/Objects/ParseUser.swift	82.25% <0.00%> (-0.37%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96232f3...afbd466. Read the comment docs.

[vdkdamian]

@Climbatize @vdkdamian can you check if this branch solves the problem?

Also check if all other functionality works as normal. I'll take a further look later...

I'll adopt to this branch now, and let you know in the next few days if any of the testers experienced issues.

[cbaker6]

Tested this on all of the playground examples and it works along with not disturbing other code. The change makes sense logically and should be fine to add as ParseObject's don't look like ParseError's.

[vdkdamian]

@cbaker6 I currently haven't experienced any issues with the change either. LGTM

[cbaker6]

@vdkdamian thanks for checking!

[MergeMaster]

I am still getting this error using ParseSwift 4.12.2 and ParseServer 5.4.0. In the server preventLoginWithUnverifiedEmail and verifyUserEmails are set to true. The error that I am getting is the one of #313.

Should I create a new issue? @cbaker6