Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polygon query not encoding properly #381

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jul 13, 2022

New Pull Request Checklist

Issue Description

The withinPolygon QueryConstraint currently does not encode ParseGeoPoint's or ParsePolygon correctly.

Related issue: #380

Approach

  • fix withinPolygon encoding for both ParseGeoPoint and ParsePolygon types
  • Swap the latitude and longitude when encoding/decoding ParsePolygon types

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 13, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@cbaker6 cbaker6 linked an issue Jul 13, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #381 (9082628) into main (926fc05) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   89.66%   89.66%   -0.01%     
==========================================
  Files         155      155              
  Lines       14123    14121       -2     
==========================================
- Hits        12663    12661       -2     
  Misses       1460     1460              
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParsePolygon.swift 97.70% <100.00%> (ø)
Sources/ParseSwift/Types/QueryConstraint.swift 98.57% <100.00%> (-0.02%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 86.20% <0.00%> (-0.09%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 85.25% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926fc05...9082628. Read the comment docs.

@cbaker6 cbaker6 merged commit 3b36877 into parse-community:main Jul 13, 2022
@cbaker6 cbaker6 deleted the polygon branch July 13, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoQuerie's withinPolygon are not working properly
1 participant