-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes un-necessary shutdown handler #3786
Conversation
- When registering a shutdown hander, the node process has to be exited manually which causes issues for many users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine, but why not just git revert 0b1d6fe
instead to tie it all together?
Yeah but that makes me realize the reason why I did that in the 1st place, which will probably fuck me up in my deployments when using the CLI purely. |
Yeah the CLI don't shutdown at all... |
Codecov Report
@@ Coverage Diff @@
## master #3786 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 114 114
Lines 7491 7491
=======================================
Hits 6761 6761
Misses 730 730
Continue to review full report at Codecov.
|
@acinader that will be better like that IMHO, what do you think? |
lgtm... i mean assuming it works ;) |
fixes #3718