Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes un-necessary shutdown handler #3786

Merged
merged 2 commits into from
May 8, 2017
Merged

Removes un-necessary shutdown handler #3786

merged 2 commits into from
May 8, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented May 7, 2017

  • When registering a shutdown hander, the node process has to be exited manually which causes issues for many users

fixes #3718

- When registering a shutdown hander, the node process has to be exited manually which causes issues for many users
@acinader acinader self-requested a review May 7, 2017 21:09
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, but why not just git revert 0b1d6fe instead to tie it all together?

@flovilmart
Copy link
Contributor Author

Yeah but that makes me realize the reason why I did that in the 1st place, which will probably fuck me up in my deployments when using the CLI purely.

@flovilmart
Copy link
Contributor Author

Yeah the CLI don't shutdown at all...

@codecov
Copy link

codecov bot commented May 7, 2017

Codecov Report

Merging #3786 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3786   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         114      114           
  Lines        7491     7491           
=======================================
  Hits         6761     6761           
  Misses        730      730
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.49% <0%> (-0.12%) ⬇️
src/ParseServer.js 88.53% <0%> (-1.73%) ⬇️
src/Controllers/SchemaController.js 97.29% <0%> (+0.24%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.72% <0%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a9d50...ae9149b. Read the comment docs.

@flovilmart
Copy link
Contributor Author

@acinader that will be better like that IMHO, what do you think?

@acinader
Copy link
Contributor

acinader commented May 8, 2017

lgtm... i mean assuming it works ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse server won't shutdown
2 participants