catch unhandled rejection with installation-handling #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3795 +/- ##
========================================
Coverage ? 90.1%
========================================
Files ? 114
Lines ? 7500
Branches ? 0
========================================
Hits ? 6758
Misses ? 742
Partials ? 0
Continue to review full report at Codecov.
|
|
Fixes #3758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as mentioned in #3758 I now found the time to fix the unhandled rejections when dealing with installations. I added catch-blocks to the delete-statements in RestWrite.js . The error is ignored when it is "ObjectNotFound". Otherwise it will be rethrown.
We already use this in our production environment without problems. And log log now no longer has "unhandled rejection" warnings.
Best regards,
Benjamin