Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Server crashes when receiving an array of Parse.Pointer in the request body #9012

Merged
merged 5 commits into from
Mar 16, 2024

Conversation

jaysonng
Copy link

@jaysonng jaysonng commented Mar 14, 2024

Pull Request

Issue

Closes: #9010

same as : #8783

Approach

Copied / exactly the same as PR #8784

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

Thanks for opening this pull request!

spec/ParseAPI.spec.js Outdated Show resolved Hide resolved
@mtrezza
Copy link
Member

mtrezza commented Mar 14, 2024

Also check lint

@mtrezza mtrezza changed the title fix: Server crashes when receiving an array of Parse.Pointer in the request body #9010 for v6.x.x fix: Server crashes when receiving an array of Parse.Pointer in the request body Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (09b6a95) to head (5465bc8).
Report is 1 commits behind head on release-6.x.x.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-6.x.x    #9012      +/-   ##
=================================================
- Coverage          94.33%   94.32%   -0.01%     
=================================================
  Files                186      186              
  Lines              14827    14827              
=================================================
- Hits               13987    13986       -1     
- Misses               840      841       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaysonng
Copy link
Author

Also check lint

weird. I see below that lint fails because of a white space.

but when I run it locally, I get

> parse-server@6.5.2 lint
> flow && eslint --cache ./

Launching Flow server for /Users/jayson/Projects/Busog/parse-server/server
Spawned flow server (pid=7154)
Logs will go to /private/tmp/flow/zSUserszSjaysonzSProjectszSBusogzSparse-serverzSserver.log
Monitor logs will go to /private/tmp/flow/zSUserszSjaysonzSProjectszSBusogzSparse-serverzSserver.monitor_log
No errors!

spec/ParseAPI.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
spec/ParseAPI.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
spec/ParseAPI.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza mtrezza merged commit 8ff444d into parse-community:release-6.x.x Mar 16, 2024
26 of 28 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 16, 2024
## [6.5.4](6.5.3...6.5.4) (2024-03-16)

### Bug Fixes

* Server crashes when receiving an array of `Parse.Pointer` in the request body ([#9012](#9012)) ([8ff444d](8ff444d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse server crash - Cannot read property 'encodeParseObjectInCloudFunction' of undefined in PS6.x.x
3 participants