Skip to content

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 23, 2025

Fixes #XXXX.

Description

Quite a few #[allow(dead_code)] lead to stagnant code lying around in the codebase, this cleans that up.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12924125300

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 12.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/event/writer/file_writer.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/hottier.rs 1 0.0%
src/storage/staging.rs 1 0.0%
src/handlers/http/cluster/utils.rs 2 0.0%
src/handlers/http/logstream.rs 2 1.71%
Totals Coverage Status
Change from base Build 12922515032: -0.05%
Covered Lines: 2446
Relevant Lines: 19131

💛 - Coveralls

@de-sh de-sh marked this pull request as ready for review January 23, 2025 10:09
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 2477b20 into parseablehq:main Jan 23, 2025
11 checks passed
@de-sh de-sh deleted the rm-dead-code branch January 23, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants