Skip to content

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Mar 19, 2025

REF: actions/runner-images#2840 (comment)

I am not entirely sure this is the true cause of our troubles(as issue stems from cache save stage and not disk), but worth trying out as there is mention of device.

We need to validate cache utilization first though, steps to do that are as follows
1. Go to your repository on GitHub.
2. Click on "Settings".
3. In the left sidebar, click on "Code and automation" then "Actions".
4. Under "Actions", click on "Caches".

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Summary by CodeRabbit

  • Chores
    • Introduced a cleanup step in the build process to optimize system performance prior to deployment.

Signed-off-by: Devdutt Shenoi <devdutt@parseable.com>
Copy link
Contributor

coderabbitai bot commented Mar 19, 2025

Walkthrough

A new cleanup step has been added in the GitHub Actions workflow file. This step, named "Cleanup GitHub runner," removes specific directories such as /usr/share/dotnet, /opt/ghc, /usr/local/share/boost, and the directory pointed by $AGENT_TOOLSDIRECTORY before the "Build and push" step in the workflow.

Changes

File(s) Change Summary
.github/.../build-push-edge-debug.yaml Added a "Cleanup GitHub runner" step that removes directories /usr/share/dotnet, /opt/ghc, /usr/local/share/boost, and $AGENT_TOOLSDIRECTORY before build.

Sequence Diagram(s)

sequenceDiagram
    participant R as GitHub Runner
    participant C as Cleanup Step
    participant B as Build and Push Step
    R->>+C: Execute "Cleanup GitHub runner" step
    C-->>-R: Directories removed
    R->>+B: Proceed to "Build and push" step
    B-->>-R: Build and push complete
Loading

Poem

Hop along, my friend, with cleanup delight,
I clear the paths for code in flight.
Directories disappear like magic dust,
Leaving space for builds we trust.
With every hop, the runner shines bright,
A rabbit's joy on a CI night! 🐰✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/build-push-edge-debug.yaml (1)

40-47: Cleanup Step for Disk Space Recovery
The newly added "Cleanup GitHub runner" step correctly targets directories known to consume significant disk space on the runner. This is a practical approach to mitigate "No space left on device" errors. To further improve reliability, consider adding a conditional check for the $AGENT_TOOLSDIRECTORY variable to ensure it is both defined and non-empty before attempting deletion. This can help avoid unintended deletions if the variable is unset or empty.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38c8b19 and 4deaf11.

📒 Files selected for processing (1)
  • .github/workflows/build-push-edge-debug.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: coverage
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: Build Kafka aarch64-apple-darwin

@de-sh de-sh closed this Mar 20, 2025
@de-sh de-sh deleted the patch-2 branch March 20, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant