-
-
Notifications
You must be signed in to change notification settings - Fork 153
ci: fix "No space left on device" #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Devdutt Shenoi <devdutt@parseable.com>
WalkthroughA new cleanup step has been added in the GitHub Actions workflow file. This step, named "Cleanup GitHub runner," removes specific directories such as Changes
Sequence Diagram(s)sequenceDiagram
participant R as GitHub Runner
participant C as Cleanup Step
participant B as Build and Push Step
R->>+C: Execute "Cleanup GitHub runner" step
C-->>-R: Directories removed
R->>+B: Proceed to "Build and push" step
B-->>-R: Build and push complete
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build-push-edge-debug.yaml (1)
40-47
: Cleanup Step for Disk Space Recovery
The newly added "Cleanup GitHub runner" step correctly targets directories known to consume significant disk space on the runner. This is a practical approach to mitigate "No space left on device" errors. To further improve reliability, consider adding a conditional check for the$AGENT_TOOLSDIRECTORY
variable to ensure it is both defined and non-empty before attempting deletion. This can help avoid unintended deletions if the variable is unset or empty.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-push-edge-debug.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: coverage
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Build Kafka aarch64-apple-darwin
REF: actions/runner-images#2840 (comment)
I am not entirely sure this is the true cause of our troubles(as issue stems from cache save stage and not disk), but worth trying out as there is mention of device.
We need to validate cache utilization first though, steps to do that are as follows
1. Go to your repository on GitHub.
2. Click on "Settings".
3. In the left sidebar, click on "Code and automation" then "Actions".
4. Under "Actions", click on "Caches".
Description
This PR has:
Summary by CodeRabbit