Skip to content

Set zip version with only deflate feature enabled #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Oct 18, 2022

Description

Set zip crate back to stable crates.io version with minimal features enabled. This gets rid of bzip2 as indirect dependency and transitively on bzip2-sys crate. Console releases on GitHub use deflate method for zip, so Parseable build step should only requires this feature.

@nitisht
Copy link
Member

nitisht commented Oct 18, 2022

@trueleo does this fix the Docker build issue we observed?

@trueleo
Copy link
Contributor Author

trueleo commented Oct 18, 2022

@trueleo does this fix the Docker build issue we observed?

Nope, only gets rid of one of the -sys crate.. that issue still persists

@nitisht
Copy link
Member

nitisht commented Oct 18, 2022

@trueleo does this fix the Docker build issue we observed?

Nope, only gets rid of one of the -sys crate.. that issue still persists

okay

@nitisht nitisht merged commit 4905c3e into parseablehq:main Oct 18, 2022
@trueleo trueleo deleted the zip_version branch October 18, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants