Skip to content

Fix LocalFS stream listing #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2023
Merged

Fix LocalFS stream listing #321

merged 3 commits into from
Feb 28, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Feb 28, 2023 •
edited
Loading

Fixes #318 .

Description

Fix listing in local storage mode. Looks for .stream.json in the directory only then counts it as a valid stream candidate

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@syepes syepes mentioned this pull request Feb 28, 2023
Closed
3 tasks
@nitisht nitisht merged commit ddb8e7e into parseablehq:main Feb 28, 2023
@trueleo trueleo deleted the localfs_fix branch March 6, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore folder lost+found
2 participants
@trueleo @nitisht