Skip to content

Fix get retention api #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix get retention api #358

merged 1 commit into from
Apr 4, 2023

Conversation

mhtocs
Copy link
Contributor

@mhtocs mhtocs commented Apr 3, 2023 •
edited
Loading

Fixes #349

Description

Adds a get api to list the retention for a stream

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht requested a review from trueleo April 3, 2023 18:08
@nitisht
Copy link
Member

nitisht commented Apr 3, 2023

Thanks @mhtocs for the PR. We'll review this soon!

nitisht
nitisht approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you again for the hard work

@nitisht nitisht merged commit 4d7298d into parseablehq:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht approved these changes

@trueleo trueleo Awaiting requested review from trueleo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: get retention API for a stream
2 participants
@mhtocs @nitisht