Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Error Message #643

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update Error Message #643

merged 2 commits into from
Jan 30, 2024

Conversation

Eshanatnight
Copy link
Contributor

Fixes #641

Description

Previously in Query Mode, All logstream endpoints were allowed.
Now only GET requests are allowed

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@Eshanatnight
Update Error Message
d9db303
@Eshanatnight
Update: In Query Mode only GET /logstream is allowed
1313283 
Previously in Query Mode, All logstream endpoints were allowed.
Now only GET requests are allowed
nitisht
nitisht approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Tested

@nitisht nitisht merged commit 90a44d6 into parseablehq:main Jan 30, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block logstream endpoint in P_MODE query
2 participants
@Eshanatnight @nitisht