enhancement to allow custom partitions in ingestion #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow - add an optional header - X-P-Custom-Partition in stream creation API with comma separated values the custom-partition will be stored in the stream.json file at the time of ingestion, below validations are put in place - 1. all events in the batch have the custom partitions 2. max of 3 partitions are allowed 3. custom partition values should not have a '.' in the log event 4. custom partition value should not be empty in the log event Prefixes will be created in the alphabetical order of the custom partition fields sort order in the parquet will be p_timestamp/time_partition and the custom partition fields same sort order will be reflected in the manifest file
fix for time-partition with/without custom-partition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow - add an optional header - X-P-Custom-Partition in stream creation API with comma separated values
the custom-partition will be stored in the stream.json file at the time of ingestion,
below validations are put in place -
Prefixes will be created in the alphabetical order of the custom partition fields
sort order in the parquet will be p_timestamp/time_partition and the custom partition fields same sort order will be reflected in the manifest file