enhancement: add stream type to stream definition #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikhilsinhaparseable
commented
Aug 10, 2024
nikhilsinhaparseable
commented
- add stream_type=UserDefined for user defined streams
- add stream_type=Internal for pmeta
- migrate existing streams' stream.json from v4 to v5
- add field stream_type in migration for existing streams
- add field stream_type in GET /logstream/{logstream}/info API
nitisht
requested changes
Aug 11, 2024
server/src/metadata.rs
Outdated
| self.read() | ||
| .expect(LOCK_EXPECT) | ||
| .iter() | ||
| .filter(|(_, v)| v.stream_type != StreamType::UserDefined) |
There was a problem hiding this comment.
Suggested change
| .filter(|(_, v)| v.stream_type != StreamType::UserDefined) | |
| .filter(|(_, v)| v.stream_type == StreamType::Internal) |
server/src/validator.rs
Outdated
| @@ -119,7 +123,7 @@ pub fn stream_name(stream_name: &str) -> Result<(), StreamNameValidationError> { | |||
| )); | |||
| } | |||
|
|
|||
| if stream_name == INTERNAL_STREAM_NAME { | |||
| if *stream_type == StreamType::Internal || stream_name == INTERNAL_STREAM_NAME { | |||
There was a problem hiding this comment.
Suggested change
| if *stream_type == StreamType::Internal || stream_name == INTERNAL_STREAM_NAME { | |
| if *stream_type == StreamType::Internal { |
1. add stream_type=UserDefined for user defined streams
2. add stream_type=Internal for pmeta
3. migrate existing streams' stream.json from v4 to v5
4. add field stream_type in migration for existing streams
5. add field stream_type in GET /logstream/{logstream}/info API
query server creates internal stream and sync with ingestors on server start no ingestion can happen from ingestor for internal stream
2. modified sync_streams_with_ingestors that can be used for all streams
nikhilsinhaparseable
force-pushed
the
define-stream-type
branch
from
599e392 to
273d022
Compare
nitisht
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.