Fix infinite loop #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
commented
Mar 22, 2022
Comment on lines
-117
to
-119
| | Just x <- flatten <$> Safe.fromException exn | ||
| = | ||
| pure x |
There was a problem hiding this comment.
I moved the flattening of exceptions into the toException, which works (per test suites)
| @@ -94,6 +115,24 @@ spec = do | |||
| exn <- subject TestException | |||
| exn `shouldBe` new TestException | |||
|
|
|||
| describe "when the wrong error is tried " $ do | |||
There was a problem hiding this comment.
Initial failing test case from the work app.
Closed
|
I've tried this out on the work codebase and all tests pass 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddock.stylish-haskelland otherwise adhered to the style guide.After submitting your PR: