Skip to content

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Apr 12, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested review from am357 and alancai98 April 12, 2024 17:37
Copy link

Conformance comparison report

Base (00c21e2) d93da39 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (00c21e2) but now fail: 0

Number failing in Base (00c21e2) but now pass: 0

Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure why the codecov step of GH Actions failed for earlier runs. Looks good otherwise.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.51%. Comparing base (00c21e2) to head (18cd9da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   80.51%   80.51%           
=======================================
  Files          66       66           
  Lines       17464    17464           
  Branches    17464    17464           
=======================================
  Hits        14061    14061           
  Misses       2964     2964           
  Partials      439      439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpschorr jpschorr merged commit 5dc7c6e into main Apr 12, 2024
@jpschorr jpschorr deleted the chore-rel-0.7.2 branch September 4, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants