Start on conformance tests for graph query. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancai98
previously approved these changes
May 26, 2023
There was a problem hiding this comment.
Set of tests ported from Kotlin look good. Only comment is that we should document in this repo somewhere the new graph type encoding in Ion. Perhaps somewhere in the partiql-tests/docs directory (could use partiql-tests-schema-proposal.md or a new file).
Good idea! Thanks for pointing at the appropriate spot! |
jpschorr
approved these changes
May 26, 2023
alancai98
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These conformance tests are ported from some of the unit tests in EvaluatingCompilerGraphMatchTests in partiql-lang-kotlin, partiql/partiql-lang-kotlin#1104
Adjustments to reading-in Ion made in #1104 are necessary for reading in and running these new conformance tests here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.