-
Notifications
You must be signed in to change notification settings - Fork 6
order price creation #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
@@ -56,6 +56,10 @@ In Patch, orders represent a purchase of carbon offsets or negative emissions by | |||
const mass = 1000000 // Pass in the mass in grams (i.e. 1 metric tonne) | |||
patch.orders.createOrder({ mass_g: mass }) | |||
|
|||
// Create an order with maximum total price | |||
const totalPriceCentsUSD = 500 // Pass in the total price in cents (i.e. 5 dollars) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add to the README that you should pick either mass_g
or total_price_cents_usd
when creating an order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a bit more context, see if that looks better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question about whether or not we should specify in the readme to pick either mass_g
or total_price_cents_usd
.
9a44206
to
d936c7e
Compare
What
total_price_cents_usd
to order creationmass_g
ortotal_price_cents_usd
, but not bothWhy
SDK Release Checklist