Skip to content

[v.1.3.0] Add support for Flight/Vehicle/Shipping estimates #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 9, 2021

Conversation

biglovisa
Copy link
Contributor

What

  • Adds support for Flight/Vehicle/Shipping estimates
  • Update to version 1.3.5

Why

  • To extend the Node package to support different kinds of estimates to be created

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@biglovisa biglovisa force-pushed the lovisa/version-1.3.5 branch from 9ce530b to 176faab Compare February 8, 2021 20:53
@biglovisa biglovisa force-pushed the lovisa/version-1.3.5 branch from 176faab to b9c454c Compare February 8, 2021 22:25
@biglovisa biglovisa requested a review from thdaraujo February 8, 2021 22:33
@biglovisa biglovisa self-assigned this Feb 8, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Feb 8, 2021
@biglovisa biglovisa changed the title [v.1.3.5] Add support for Flight/Vehicle/Shipping estimates [v.1.3.0] Add support for Flight/Vehicle/Shipping estimates Feb 8, 2021
@biglovisa biglovisa force-pushed the lovisa/version-1.3.5 branch from bb77b63 to 9b145db Compare February 8, 2021 23:53
@biglovisa biglovisa force-pushed the lovisa/version-1.3.5 branch from 9b145db to 2449eab Compare February 8, 2021 23:55
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but not sure about the defaulthost. Why the change?

src/ApiClient.js Outdated
@@ -411,7 +411,7 @@ class ApiClient {
hostSettings() {
return [
{
url: 'https://api.usepatch.com',
url: 'https://{defaultHost}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change this? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, we do not change this. I'll see about fixing this in the code generator repo...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a PR up to fix this in the other repo!

@thdaraujo thdaraujo added Ready This PR is ready to ship! and removed Needs Review The PR is ready to be reviewed labels Feb 9, 2021
@biglovisa biglovisa force-pushed the lovisa/version-1.3.5 branch from 7fa8201 to 18a2842 Compare February 9, 2021 16:04
@biglovisa biglovisa force-pushed the lovisa/version-1.3.5 branch from 18a2842 to ed8dc78 Compare February 9, 2021 16:13
@biglovisa biglovisa force-pushed the lovisa/version-1.3.5 branch from 5c0342f to c3e3887 Compare February 9, 2021 17:11
@biglovisa biglovisa merged commit 93e880f into main Feb 9, 2021
@biglovisa biglovisa deleted the lovisa/version-1.3.5 branch February 9, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready This PR is ready to ship!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants