-
Notifications
You must be signed in to change notification settings - Fork 6
[v.1.3.0] Add support for Flight/Vehicle/Shipping estimates #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ce530b
to
176faab
Compare
176faab
to
b9c454c
Compare
bb77b63
to
9b145db
Compare
9b145db
to
2449eab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but not sure about the defaulthost. Why the change?
src/ApiClient.js
Outdated
@@ -411,7 +411,7 @@ class ApiClient { | |||
hostSettings() { | |||
return [ | |||
{ | |||
url: 'https://api.usepatch.com', | |||
url: 'https://{defaultHost}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to change this? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, we do not change this. I'll see about fixing this in the code generator repo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a PR up to fix this in the other repo!
7fa8201
to
18a2842
Compare
18a2842
to
ed8dc78
Compare
5c0342f
to
c3e3887
Compare
What
Why
SDK Release Checklist
For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?