Skip to content

Filter projects #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 18, 2021
Merged

Filter projects #24

merged 4 commits into from
Feb 18, 2021

Conversation

biglovisa
Copy link
Contributor

@biglovisa biglovisa commented Feb 17, 2021 •
edited
Loading

What

  • Add filtering to retrieveProjects

Why

  • So you can get more specific results from the API.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@biglovisa biglovisa force-pushed the lovisa/filter-projects branch from fe4603a to 123cdac Compare February 17, 2021 16:26
@biglovisa biglovisa requested a review from thdaraujo February 17, 2021 16:26
@biglovisa biglovisa self-assigned this Feb 17, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Feb 17, 2021
thdaraujo
thdaraujo approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is the version right?

package-lock.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@patch-technology/patch",
"version": "1.2.5",
"version": "1.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4? 🤔

@thdaraujo thdaraujo added Ready This PR is ready to ship! and removed Needs Review The PR is ready to be reviewed labels Feb 17, 2021
@biglovisa biglovisa force-pushed the lovisa/filter-projects branch from ca5e780 to 3155b72 Compare February 18, 2021 00:22
@biglovisa biglovisa merged commit d6f8cd7 into main Feb 18, 2021
@biglovisa biglovisa deleted the lovisa/filter-projects branch February 18, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees

@biglovisa biglovisa

Labels
Ready This PR is ready to ship!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biglovisa @thdaraujo