Skip to content

Update health check #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

Update health check #27

merged 1 commit into from
Mar 8, 2021

Conversation

biglovisa
Copy link
Contributor

What

  • Updating the healthcheck to notify in slack on the test step

Why

This action was misconfigured before! Now it should post notifications to slack based on the rspec run step.

SDK Release Checklist

N/A

@biglovisa biglovisa self-assigned this Mar 6, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Mar 6, 2021
@biglovisa biglovisa requested a review from a team March 6, 2021 00:18
thdaraujo
thdaraujo approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool \o/

@biglovisa biglovisa merged commit 8284df8 into main Mar 8, 2021
@biglovisa biglovisa deleted the lovisa/update-healthcheck branch March 8, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees

@biglovisa biglovisa

Labels
Needs Review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biglovisa @thdaraujo