Add bitcoin estimates and registry_url #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcothenet
commented
Jul 13, 2021
| strategy: | ||
| matrix: | ||
| node: ['10', '12', '14'] | ||
| node: ['10', '12', '14', '16'] |
There was a problem hiding this comment.
Adding node 16, which is getting common. Node 10 is EOL and could be removed in the future (AWS dropped support recently)
Comment on lines
+1
to
+2
| require: '@babel/register' | ||
| recursive: true No newline at end of file |
There was a problem hiding this comment.
Switching to the non-deprecated config format for mocha options.
pcothenet
commented
Jul 13, 2021
Comment on lines
-26
to
-31
| expect(parseFloat(createOrderResponse.data.price_cents_usd)).to.be.closeTo( | ||
| 500, | ||
| 1 | ||
| ); | ||
| expect(createOrderResponse.data.patch_fee_cents_usd).to.equal('0.0'); | ||
| expect(createOrderResponse.data.mass_g).to.equal(500000); |
There was a problem hiding this comment.
Existing values were not working after we changed billing. This should have been updated, but most importantly caught by the health check. It did, but we weren't paying attention (I don't know where the alerts went). I'll take a closer look when we strengthen the SDK.
bspellacy
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
SDK Release Checklist
For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?