Skip to content

Bump nvm version #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2021
Merged

Bump nvm version #36

merged 1 commit into from
Aug 27, 2021

Conversation

pcothenet
Copy link
Contributor

What

  • Matches the node version used to build the library

Why

  • Consistency between our apps

Notes

  • We still babel to node 10, so this should not impact the published packages

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from kleinjm August 27, 2021 02:49
kleinjm
kleinjm approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@kleinjm kleinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@pcothenet pcothenet merged commit fec2049 into main Aug 27, 2021
@pcothenet pcothenet deleted the pc/nvm branch August 27, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinjm kleinjm kleinjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @kleinjm