Skip to content

Fix AttributeError when retrieving Projects with SDGs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix AttributeError when retrieving Projects with SDGs #21

merged 1 commit into from
Mar 2, 2021

Conversation

biglovisa
Copy link
Contributor

What

  • Requiring the SDG model in models/__init__.py to ensure we can retrieve Projects with SDGs without errors.

Why

  • So that we can retrieve all Projects.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@biglovisa biglovisa requested review from pcothenet and thdaraujo March 2, 2021 18:18
@biglovisa biglovisa self-assigned this Mar 2, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Mar 2, 2021
@biglovisa biglovisa merged commit 8e247e8 into main Mar 2, 2021
@biglovisa biglovisa deleted the lovisa/fix-sdg branch March 2, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcothenet pcothenet pcothenet approved these changes

@thdaraujo thdaraujo Awaiting requested review from thdaraujo

Assignees

@biglovisa biglovisa

Labels
Needs Review The PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biglovisa @pcothenet