Remove the preferences endpoints #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcothenet
commented
Dec 7, 2021
| @@ -3,4 +3,4 @@ | |||
| # W504 is the "line break before binary operator" error and is disabled since we use | |||
| # the black code formatter. | |||
| # W503 is disabled by default, but must be disabled explicitly when using `ignore`. | |||
| ignore = E501, W503, W504 | |||
| ignore = E501, W503, W504, F401 | |||
There was a problem hiding this comment.
Disables an error about module imported but not used that is hard to fix without changing the templates.
The python SDK is due for an overhaul soon, so not worth digging in.
pcothenet
commented
Dec 7, 2021
Comment on lines
-211
to
+212
| _request_timeout, (int,) if six.PY3 else (int, long) | ||
| ): # noqa: E501,F821 | ||
| _request_timeout, (int,) if six.PY3 else (int, int) | ||
| ): # noqa: E501 |
There was a problem hiding this comment.
This fixes the flake8 warning (and has been updated in the template). long has been deprecated in python 3
kleinjm
approved these changes
Dec 8, 2021
alianam
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
SDK Release Checklist